Skip to content

Fix: Remove unnecessary button and link props from Apply page timeline#662

Merged
Zahnentferner merged 3 commits intoAOSSIE-Org:mainfrom
Aarya-Chaudhari:code
Mar 14, 2026
Merged

Fix: Remove unnecessary button and link props from Apply page timeline#662
Zahnentferner merged 3 commits intoAOSSIE-Org:mainfrom
Aarya-Chaudhari:code

Conversation

@Aarya-Chaudhari
Copy link
Contributor

@Aarya-Chaudhari Aarya-Chaudhari commented Mar 13, 2026

Addressed Issues:

Fixes #645

Problem
On the /apply page, the vertical timeline displays the steps involved in the GSOC application process such as:
Join us on Discord
Start Contributing
Write a Draft Application
Discuss with Mentors
Submit Application
In src/app/apply/page.jsx, each TimelineElement was receiving button and link props. However, these props were not used for navigation or rendering any interactive elements in the UI.

Keeping unused props can be misleading for contributors, as it suggests that the timeline elements are interactive when they are actually meant to be static informational steps.

Solution
Removed the unused button and link props from all TimelineElement usages in:
src/app/apply/page.jsx
Now the component only receives the required props:

Result
The timeline UI and behavior remain unchanged.
The codebase is cleaner and easier to understand.
Removes unnecessary props that could confuse contributors.

Testing
Ran the development server using npm run dev.
Verified the /apply page renders correctly.
Confirmed the timeline steps display exactly as before with no visual changes.

Files Modified
src/app/apply/page.jsx

Screenshots/Recordings:

Code Before:
Screenshot 2026-03-13 175925

Code After Changes:
Screenshot 2026-03-13 175946

Additional Notes:

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Warning

Rate limit exceeded

@Aarya-Chaudhari has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c18010a-8f8d-4200-90ae-73ba5dcd0be1

📥 Commits

Reviewing files that changed from the base of the PR and between 8c97742 and 1716a66.

📒 Files selected for processing (1)
  • src/app/apply/page.jsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Aarya-Chaudhari
Copy link
Contributor Author

Hello @Zahnentferner
I have raised a PR resolving issue #645.
Could you please review and let me know if any changes required.
Thanks

@Zahnentferner
Copy link
Collaborator

Thanks!

@Zahnentferner Zahnentferner merged commit c309ae3 into AOSSIE-Org:main Mar 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]:Remove unnecessary button and link props from Apply page timeline

2 participants